Skip to content

Corrects use of XCTAssertEqual macro in parallelization examples. #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented Feb 18, 2025

Fixes a typo in the "before" example of adopting test serialization.

Motivation:

The example of XCTest tests that need to run in series doesn't compile.

Modifications:

Correct the code in the example.

Result:

A documentation change that means the code snippet in the example is correct.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added the documentation 📚 Improvements or additions to documentation label Feb 18, 2025
@stmontgomery stmontgomery added this to the Swift 6.x milestone Feb 18, 2025
@stmontgomery
Copy link
Contributor

stmontgomery commented Feb 18, 2025

Follow-on to #960
Fixes #863

@iamleeg iamleeg merged commit 85bfa51 into main Feb 18, 2025
@iamleeg iamleeg deleted the iamleeg/122918733-fix-typo-in-test-examples branch February 18, 2025 16:57
@grynspan grynspan added the bug 🪲 Something isn't working label Feb 18, 2025
iamleeg added a commit that referenced this pull request Feb 19, 2025
Fixes a typo in the "before" example of adopting test serialization.

### Motivation:

The example of XCTest tests that need to run in series doesn't compile.

### Modifications:

Correct the code in the example.

### Result:

A documentation change that means the code snippet in the example is
correct.

### Checklist:

- [X] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [X] If public symbols are renamed or modified, DocC references should
be updated.
iamleeg added a commit that referenced this pull request Feb 19, 2025
…uide (#965)

- **Explanation**:
Updates the article on migrating tests from XCTest to tell developers
about test serialization.
  - **Scope**:
Documentation updates.
  - **Issues**:
#863 
  - **Original PRs**:
#960 #963 
  - **Risk**:
Purely documentation updates, no risk to the release.
  - **Testing**:
Build documentation and read Migrating a test from XCTest.
  - **Reviewers**:
@grynspan @stmontgomery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working documentation 📚 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants