Skip to content

TSCBasic: use the "portable" names for terminalType #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020
Merged

TSCBasic: use the "portable" names for terminalType #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/TSCBasic/TerminalController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,15 @@ public final class TerminalController {

/// Computes the terminal type of the stream.
public static func terminalType(_ stream: LocalFileOutputByteStream) -> TerminalType {
#if os(Windows)
return _isatty(_fileno(stream.filePointer)) == 0 ? .file : .tty
#else
if ProcessEnv.vars["TERM"] == "dumb" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this not needed on windows?

Copy link
Member Author

@compnerd compnerd Aug 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed on Windows - there is no terminal emulator environment variable on Windows. You cannot query whether the current emulator is a dumb terminal or not because there never was the concept of a dumb terminal for Windows. It is a purely graphical environment, and so the only terminal emulator that is available is guaranteed to not be a dumb terminal. That said, using that as an approximation of whether the terminal emulator supports extended ASCII codes or not is not really viable on Windows. You do not have a way to query that and the best you can do is assume that the terminal emulator understands the extended VT220 ANSI escape codes (which it does if it is Windows Terminal) and let the terminal display the sequence if it does not (e.g. it is the old ConHost.exe process hosting the Windows console).

return .dumb
}
let isTTY = isatty(fileno(stream.filePointer)) != 0
return isTTY ? .tty : .file
#endif
}

/// Tries to get the terminal width first using COLUMNS env variable and
Expand Down