TSCTestSupport: remove PseudoTerminal on Windows temporarily
#112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While swift-package-manager is being brought up on Windows, we do not have the tests running. Windows does not have the `pty` concept nor the supporting APIs. For now disable the class to allow swift-tools-support-core to build on Windows with swift-package-manager which is required to bootstrap swift-package-manager.
|
@swift-ci please test |
|
I am fine with this as a temp measure. should we document / spit out a warning or somehow remind ourselves to fix it? |
tomerd
approved these changes
Aug 14, 2020
|
Doesn't hurt: https://bugs.swift.org/browse/SR-13394 This will just pop out anyways once we get further along and try to get the test suite working :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While swift-package-manager is being brought up on Windows, we do not
have the tests running. Windows does not have the
ptyconcept nor thesupporting APIs. For now disable the class to allow
swift-tools-support-core to build on Windows with swift-package-manager
which is required to bootstrap swift-package-manager.