Skip to content

Fix and use posix_spawn_file_actions_addchdir_np() check for Android #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix and use posix_spawn_file_actions_addchdir_np() check for Android #113

merged 1 commit into from
Aug 18, 2020

Conversation

finagolfin
Copy link
Member

This function and __GLIBC_PREREQ() are not available in Bionic.

@MaxDesiatov
Copy link
Contributor

@swift-ci please test

MaxDesiatov
MaxDesiatov approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@tomerd
Copy link
Contributor

tomerd commented Aug 17, 2020

cc @compnerd

compnerd
compnerd approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up @buttaface!

@tomerd tomerd merged commit 6f8a6d6 into swiftlang:master Aug 18, 2020
@finagolfin
Copy link
Member Author

Thanks for the quick review.

@finagolfin finagolfin deleted the droid branch August 18, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees

@abertelrud abertelrud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@finagolfin @MaxDesiatov @tomerd @compnerd @abertelrud