Rely on autolinking for SQLite on macOS #115
Conversation
|
@swift-ci please test |
There was a problem hiding this comment.
Looks good to me. In my testing, I didn't actually have to conditionalize the find_package to get it working. I don't know whether not running that on Darwin has problems, e.g. it might be setting up variables that are needed. In my case I just removed the target_link_libraries on Darwin to get it working.
neonichu
force-pushed
the
optional-sqlite
branch
from
3f59b6e to
e9e4085
Compare
|
@swift-ci please test |
There was a problem hiding this comment.
This looks good to me now, and is what got my local build working again, even in the presence of SDKs that have only .tbd files (there might be an underlying CMake issue there as well, if it's assuming .dylib files for SDK libraries). It's conceptually reasonable to use auto link here, I think, since SQLite is an SDK library.
No description provided.