Move Triple to TSCUtility

[neonichu]

We need to use Triple in SwiftPM's ManifestLoader as part of some upcoming changes and that requires moving it here.

[neonichu]

@swift-ci please test

[airspeedswift]

ಠ_ಠ

[abertelrud]

This is just being moved over from SwiftPM, right? Eventually we'll need to fix this. If it's new code, then we should fix it from the start.

[neonichu]

Yah, it's just being moved over. Fix it in what sense?

[abertelrud]

I meant to not include the hardcoded architecture.

[neonichu]

Right, that's only being used for this fallback case anyway: https://github.com/apple/swift-package-manager/blob/master/Sources/SPMBuildCore/Triple.swift#L147-L150

I think we can probably remove that at this point and this static member with it, but I'd like to be conservative for now since this will need to end up in a 5.3.x release.

[compnerd]

I seem to be seeing this after this change:

FAILED: lib/libBuild.so Sources/Build/CMakeFiles/Build.dir/BuildDelegate.swift.o Sources/Build/CMakeFiles/Build.dir/BuildOperation.swift.o Sources/Build/CMakeFiles/Build.dir/BuildPlan.swift.o Sources/Build/CMakeFiles/Build.dir/ManifestBuilder.swift.o Sources/Build/CMakeFiles/Build.dir/SwiftCompilerOutputParser.swift.o Sources/Build/CMakeFiles/Build.dir/XCFrameworkInfo.swift.o swift/Build.swiftmodule 
: && /home/ci/AzureAgent/_work/25/toolchain-linux-x64/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/bin/swiftc -output-file-map Sources/Build/CMakeFiles/Build.dir/output-file-map.json -incremental -num-threads 16 -emit-library -o lib/libBuild.so -module-name Build -module-link-name Build -emit-module -emit-module-path swift/Build.swiftmodule -emit-dependencies -DBuild_EXPORTS -resource-dir /home/ci/AzureAgent/_work/25/sdk-linux-x64/Library/Developer/Platforms/Linux.platform/Developer/SDKs/Linux.sdk/usr/lib/swift -use-ld=lld   -swift-version 5 -Xcc -I -I swift -I /home/ci/AzureAgent/_work/25/a/tsc/swift -I /home/ci/AzureAgent/_work/25/s/swift-tools-support-core/Sources/TSCclibc/include -I /home/ci/AzureAgent/_work/25/a/llbuild/products/llbuildSwift -I /home/ci/AzureAgent/_work/25/s/swift-llbuild/products/libllbuild/include -I /home/ci/AzureAgent/_work/25/s/Yams/Sources/CYaml/include -I /home/ci/AzureAgent/_work/25/b/Yams/swift -I /home/ci/AzureAgent/_work/25/b/swift-driver/swift /home/ci/AzureAgent/_work/25/s/swift-package-manager/Sources/Build/BuildDelegate.swift /home/ci/AzureAgent/_work/25/s/swift-package-manager/Sources/Build/BuildOperation.swift /home/ci/AzureAgent/_work/25/s/swift-package-manager/Sources/Build/BuildPlan.swift /home/ci/AzureAgent/_work/25/s/swift-package-manager/Sources/Build/ManifestBuilder.swift /home/ci/AzureAgent/_work/25/s/swift-package-manager/Sources/Build/SwiftCompilerOutputParser.swift /home/ci/AzureAgent/_work/25/s/swift-package-manager/Sources/Build/XCFrameworkInfo.swift  -Xlinker -soname -Xlinker libBuild.so -L /home/ci/AzureAgent/_work/25/a/spm/lib  -L /home/ci/AzureAgent/_work/25/a/spm/lib  -L /home/ci/AzureAgent/_work/25/b/swift-driver/lib  -L /home/ci/AzureAgent/_work/25/a/spm/lib  -L /home/ci/AzureAgent/_work/25/a/spm/lib  -L /home/ci/AzureAgent/_work/25/a/spm/lib  -L /home/ci/AzureAgent/_work/25/a/spm/lib  -L /home/ci/AzureAgent/_work/25/a/spm/lib  -L /home/ci/AzureAgent/_work/25/b/Yams/lib  -L /home/ci/AzureAgent/_work/25/b/Yams/lib  -L /home/ci/AzureAgent/_work/25/a/tsc/lib  -L /home/ci/AzureAgent/_work/25/b/swift-driver/lib  -L /home/ci/AzureAgent/_work/25/a/tsc/lib  -L /home/ci/AzureAgent/_work/25/a/tsc/lib  -L /home/ci/AzureAgent/_work/25/a/tsc/lib  -L /home/ci/AzureAgent/_work/25/a/llbuild/lib  -L /home/ci/AzureAgent/_work/25/a/llbuild/lib  -L /usr/lib/gcc/x86_64-linux-gnu/7.4.0  -L /home/ci/AzureAgent/_work/25/toolchain-linux-x64/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/lib lib/libLLBuildManifest.so lib/libSPMBuildCore.so /home/ci/AzureAgent/_work/25/b/swift-driver/lib/libSwiftDriver.so lib/libPackageGraph.so lib/libPackageLoading.so lib/libSPMLLBuild.so lib/libPackageModel.so lib/libSourceControl.so /home/ci/AzureAgent/_work/25/b/Yams/lib/libCYaml.so /home/ci/AzureAgent/_work/25/b/Yams/lib/libYams.so /home/ci/AzureAgent/_work/25/a/tsc/lib/libTSCUtility.so -lFoundationNetworking /home/ci/AzureAgent/_work/25/b/swift-driver/lib/libSwiftOptions.so /home/ci/AzureAgent/_work/25/a/tsc/lib/libTSCBasic.so /home/ci/AzureAgent/_work/25/a/tsc/lib/libTSCLibc.so /home/ci/AzureAgent/_work/25/a/tsc/lib/libTSCclibc.a -lFoundation /home/ci/AzureAgent/_work/25/a/llbuild/lib/libllbuildSwift.so /home/ci/AzureAgent/_work/25/a/llbuild/lib/libllbuild.so -lgcc -lgcc_s -lc -lgcc -lgcc_s && :
/home/ci/AzureAgent/_work/25/s/swift-package-manager/Sources/Build/BuildPlan.swift:1896:23: error: 'Triple' is ambiguous for type lookup in this context
fileprivate extension Triple.OS {
                      ^~~~~~
/home/ci/AzureAgent/_work/25/s/swift-tools-support-core/Sources/TSCUtility/Triple.swift:21:15: note: found this candidate
public struct Triple: Encodable, Equatable {
              ^
/home/ci/AzureAgent/_work/25/s/swift-package-manager/Sources/SPMBuildCore/Triple.swift:21:15: note: found this candidate
public struct Triple: Encodable, Equatable {
              ^
ninja: build stopped: subcommand failed.

Is there supposed to be an associated s-p-m change?

[compnerd]

swiftlang/swift-package-manager#2885 should hopefully address it