Remove more environment variables when launching inferior swift-test binaries from Xcode to prevent a timeout #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binaries from Xcode, so they don't hang while trying to connect to Xcode. There is already a superior xctest invocation that's using them, and we need to make sure we're not passing them on so that the xctest invocation being invoked by swift-test thinks it's invoked directly from Xcode. We should possibly be filtering out all environment variables prefixed with "XCTest", or maybe even better, use an allow-list of environment variables to avoid having the environment leaking into the test. rdar://68362616
|
@swift-ci please test |
neonichu
approved these changes
Sep 4, 2020
abertelrud
deleted the
eng/68362616-swiftpm-unit-tests-are-timing-out-in-xcode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These environment variables are intended for the superior xctest invocation, and we need to make sure we're not passing them on so that the xctest invocation being invoked by swift-test thinks it's invoked directly from Xcode. We should possibly be filtering out all environment variables prefixed with "XCTest", or maybe even better, use an allow-list of environment variables to avoid having the environment leaking into the test. But this is a minimal change that gets these unit tests working again from Xcode.
rdar://68362616