NFC: Rename OutputByteStream to WritableByteStream for a more semantic meaning of the type. #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c meaning of the type.
sergiocampama
requested review from
aciidgh,
friedbunny and
neonichu
as code owners
|
Seems more confusing to me to have two names for the same type? 🤔 |
The type alias should be temporary, or do you think I can remove it and force update on clients when they adopt the new version? |
|
Ah, OK, it wasn't clear to me that this is supposed to be temporary, then it seems fine to me. |
neonichu
approved these changes
Sep 17, 2020
|
@swift-ci please test |
compnerd
added a commit
to compnerd/swift-tools-support-core
that referenced
this pull request
Sep 17, 2020
The file was misnamed but was not caught during review. This fixes the file name to repair the build.
compnerd
added a commit
that referenced
this pull request
Sep 17, 2020
TSCBasic: repair build after #125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just replaces the OutputByteStream type name with
WritableByteStream. The implementation classes of this protocol were not renamed to avoid messing with the types too much, and a OutputByteBuffer typealias was added to prevent breakages because of this change.