Skip to content

TSCBasic: repair the build on Windows after #139 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

compnerd
Copy link
Member

Import WinSDK to get access to SwitchToThread.

Import WinSDK to get access to `SwitchToThread`.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Oct 21, 2020

CC: @tgymnich

@neonichu
Copy link
Contributor

Sorry, updating the CI had some unexpected fallout, working through it in #148

The good news is that once that is done, we can get rid of the vendored TSC in SwiftPM.

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI going green

@compnerd
Copy link
Member Author

@swift-ci please test

1 similar comment
@neonichu
Copy link
Contributor

@swift-ci please test

@neonichu
Copy link
Contributor

Ah right, we still need the workspace.

@neonichu
Copy link
Contributor

@swift-ci please test

@neonichu neonichu merged commit b849bfa into swiftlang:main Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants