Skip to content

Rename "await" to "tsc_await" #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Rename "await" to "tsc_await" #164

merged 1 commit into from
Nov 9, 2020

Conversation

DougGregor
Copy link
Member

To aid with (further) source compatibility testing, rename await to
tsc_await to get it out of the way of the use of the await keyword
in Swift's Concurrency design. Leave the await here as deprecated
entry points so we don't break any code in the process.

Cloned over from swiftlang/swift-package-manager#3036

To aid with (further) source compatibility testing, rename `await` to
`tsc_await` to get it out of the way of the use of the `await` keyword
in Swift's Concurrency design. Leave the `await` here as deprecated
entry points so we don't break any code in the process.
@DougGregor
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know who the various clients of TSC are, and what the plan is to update them (besides SwiftPM of course)? With a lot more activity requiring clients to update (even for good reasons), perhaps it's time to properly version TSC and switch the clients to use the versions.

@DougGregor
Copy link
Member Author

Do we know who the various clients of TSC are, and what the plan is to update them (besides SwiftPM of course)? With a lot more activity requiring clients to update (even for good reasons), perhaps it's time to properly version TSC and switch the clients to use the versions.

That might be reasonable. For this particular case, we can leave the await entry point around for clients that aren't going to try to build with concurrency enabled, so we won't break anyone yet... but TSC has enough clients now that proper versioning would likely help us.

(At the moment, I'm trying to get far enough to build a toolchain for more testing, so TSC + SwiftPM is the target)

@DougGregor DougGregor merged commit 99ae28c into main Nov 9, 2020
@DougGregor DougGregor deleted the prefix-await branch November 9, 2020 07:52
@abertelrud
Copy link
Contributor

Right, understood, and agreed in this particular case. There has been at least a couple of cases of revlock between TSC and SwiftPM in the past week, and so I think we should start versioning TSC so that clients can adopt changes at their pace. I'll start some conversations about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants