Skip to content

mark argument parser as deprecated #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2021
Merged

mark argument parser as deprecated #194

merged 2 commits into from
Mar 8, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Feb 24, 2021

motivation: swift-argument-parser replaces this custom functionality, and SWiftPM has long migrated over

changes:

  • mark all argument parsing APIs as deprecated
  • remove the "TSCTestSupportExecutable" which is not used and uses the custom argument parser

@tomerd
deprecate argument parser functionality
ed37ad3 
motivation: swift-argument-parser replaces this custom functionality, and SWiftPM has long migrated over

changes:
* mark all argument parsing APIs as deprecated
* remove the "TSCTestSupportExecutable" which is not used and uses the custom argument parser
@tomerd
Copy link
Contributor Author

tomerd commented Feb 24, 2021

@swift-ci please test

@tomerd tomerd changed the title deprecate argument parser functionality mark argument parser as deprecated Feb 24, 2021
@neonichu
Copy link
Contributor

12:35:14 Fatal error: 'try!' expression unexpectedly raised an error: could not find executable for '/Users/buildnode/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-tools-support-core/.build/x86_64-apple-macosx/debug/TSCTestSupportExecutable': file TSCBasicTests/LockTests.swift, line 41

Looks like it is used by some test :)

@tomerd
Copy link
Contributor Author

tomerd commented Feb 24, 2021 •
edited
Loading

interesting, I guess those dont run locally when running them in Xcode!

Ha! they passed locally since there was a cached executable :D

@tomerd
Copy link
Contributor Author

tomerd commented Feb 24, 2021

@swift-ci please test

@neonichu
Copy link
Contributor

Ha! they passed locally since there was a cached executable :D

That seems like a bug in itself. At least in Xcode, stale file removal should kick in and remove the executable. In swift build, we haven't implemented stale file removal, so there it would be expected.

@tomerd
Copy link
Contributor Author

tomerd commented Feb 24, 2021

makes sense -- I was testing in Xcode

@abertelrud abertelrud merged commit 0054181 into swiftlang:main Mar 8, 2021
This was referenced May 30, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@abertelrud abertelrud abertelrud approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomerd @neonichu @abertelrud