Skip to content

Disable LockTests.testReadWriteFileLock #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

benlangmuir
Copy link
Contributor

This test may fail spuriously if a reader thread runs before any writers
were able to write the initial value to the file. Disable the test until
it can be fixed. We saw the same issue with FileSystemTests in the past.

rdar://78461378

This test may fail spuriously if a reader thread runs before any writers
were able to write the initial value to the file. Disable the test until
it can be fixed. We saw the same issue with FileSystemTests in the past.

rdar://78461378
@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

@benlangmuir
Copy link
Contributor Author

@tomerd FYI this looks like the same sort issue you fixed in #199, just in a different test.

@benlangmuir
Copy link
Contributor Author

@swift-ci please test

@benlangmuir
Copy link
Contributor Author

The Linux failure looks like a configuration issue unrelated to this PR:

11:22:36 error: could not decode frontend target info; compiler driver and frontend executables may be incompatible
11:22:36 details: frontend: /home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/latest_toolchain/swift-5.3-RELEASE-ubuntu16.04/usr/bin/swift
11:22:36          arguments: ["-frontend", "-print-target-info", "-target", "x86_64-unknown-linux-gnu", "-sdk", "/home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/branch-main/build/buildbot_incremental/swift-linux-x86_64/stdlib/public/core", "-resource-dir", "/home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/branch-main/build/buildbot_incremental/swift-linux-x86_64/lib/swift", "-runtime-compatibility-version", "none"]
11:22:36          error: key missing: CodingKeys(stringValue: "compilerVersion", intValue: nil), path: []

@shahmishal shahmishal merged commit fc5b8a5 into swiftlang:main May 25, 2021
@benlangmuir benlangmuir deleted the disable-test-spurious-fail branch May 25, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants