Skip to content

fix flaky test #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021
Merged

fix flaky test #216

merged 1 commit into from
Jun 9, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented May 25, 2021

motivation: LockTests.testReadWriteFileLock can race read and write threads causing unstable results and failing tests

changes:

  • write zero value to file before starting and reading or writing operations

motivation: LockTests.testReadWriteFileLock can race read and write threads causing unstable results and failing tests

changes:
* write zero value to file before starting and reading or writing operations
@tomerd
Copy link
Contributor Author

tomerd commented May 25, 2021

@swift-ci please test

Copy link
Contributor

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @tomerd!

@tomerd
Copy link
Contributor Author

tomerd commented May 26, 2021

16:25:13 warning: Could not read SDKSettings.json for SDK at: /home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/branch-main/build/buildbot_incremental/swift-linux-x86_64/stdlib/public/core
16:25:13 error: could not decode frontend target info; compiler driver and frontend executables may be incompatible
16:25:13 details: frontend: /home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/latest_toolchain/swift-5.3-RELEASE-ubuntu16.04/usr/bin/swift
16:25:13          arguments: ["-frontend", "-print-target-info", "-target", "x86_64-unknown-linux-gnu", "-sdk", "/home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/branch-main/build/buildbot_incremental/swift-linux-x86_64/stdlib/public/core", "-resource-dir", "/home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/branch-main/build/buildbot_incremental/swift-linux-x86_64/lib/swift", "-runtime-compatibility-version", "none"]
16:25:13          error: key missing: CodingKeys(stringValue: "compilerVersion", intValue: nil), path: []
16:25:13 output
16:25:13 : "{

@shahmishal this look like some CI config issue, or wrong/bad driver version? all linux PRs are failing with it

@tomerd
Copy link
Contributor Author

tomerd commented May 28, 2021

@swift-ci please test linux

2 similar comments
@shahmishal
Copy link
Member

@swift-ci please test linux

@tomerd
Copy link
Contributor Author

tomerd commented Jun 9, 2021

@swift-ci please test linux

@tomerd tomerd merged commit 9039f3a into swiftlang:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants