Extend the availability annotations for the Netrc support to cover all the Darwin platforms #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l the Darwin platforms This extends the availability based on the version numbers in the annotation for `NSTextCheckingResult.range(withName name: String) -> NSRange`. Otherwise, ToolsSupportCore can no longer build on for example iOS, because the default minimum deployment targets for the various platforms are really old (e.g. iOS 9).
abertelrud
requested review from
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
The Linux failure seem odd: |
|
It's while building |
|
There shouldn't really be a need to build the Swift compiler, but it doesn't seem that TSC supports smoke tests. |
|
@swift-ci please test linux |
|
Failed again. Looks like we're building with |
|
@swift-ci please test linux |
tomerd
approved these changes
Jun 7, 2021
@shahmishal CI infra issue? |
|
swiftlang/swift#37837 |
tomerd
approved these changes
Jun 9, 2021
abertelrud
added a commit
that referenced
this pull request
Jun 12, 2021
…ver all the Darwin platforms (#218) This extends the availability based on the version numbers in the annotation for `NSTextCheckingResult.range(withName name: String) -> NSRange`. Otherwise, ToolsSupportCore can no longer build on for example iOS, because the default minimum deployment targets for the various platforms are really old (e.g. iOS 9). (cherry picked from commit d6c996e)
abertelrud
added a commit
that referenced
this pull request
Jun 14, 2021
…ver all the Darwin platforms (#218) (#223) This extends the availability based on the version numbers in the annotation for `NSTextCheckingResult.range(withName name: String) -> NSRange`. Otherwise, ToolsSupportCore can no longer build on for example iOS, because the default minimum deployment targets for the various platforms are really old (e.g. iOS 9). (cherry picked from commit d6c996e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the availability annotation for the Netrc support to cover all the version numbers for the various Darwin platforms in the annotation for
NSTextCheckingResult.range(withName name: String) -> NSRangein the SDK. Otherwise, ToolsSupportCore can no longer build on non-macOS Darwin platforms such as iOS, because the default minimum deployment targets for the various platforms are really old (e.g. iOS 9).