TSCBasic: correct a use-after-free on Windows #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects a use-after-free caused by a pointer escape. The lifetime of the pointer is not guaranteed, and the OS may free the pointer early, particularly with OSSA. Push the handling into the closure to ensure that the lifetime is extended for the duration.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
|
@tomerd @abertelrud - I think that we should get this merged and then backported to 5.5. I was able to trigger this pretty consistently :-(. |
tomerd
approved these changes
Jun 28, 2021
|
@compnerd sgmt - please prepare a 5.5 patch |
compnerd
added a commit
that referenced
this pull request
Jun 28, 2021
This corrects a use-after-free caused by a pointer escape. The lifetime of the pointer is not guaranteed, and the OS may free the pointer early, particularly with OSSA. Push the handling into the closure to ensure that the lifetime is extended for the duration.
compnerd
added a commit
to compnerd/swift-tools-support-core
that referenced
this pull request
Jul 19, 2021
This corrects a use-after-free caused by a pointer escape. The lifetime of the pointer is not guaranteed, and the OS may free the pointer early, particularly with OSSA. Push the handling into the closure to ensure that the lifetime is extended for the duration.
drexin
added a commit
that referenced
this pull request
Jul 19, 2021
TSCBasic: correct a use-after-free on Windows (#232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a use-after-free caused by a pointer escape. The lifetime
of the pointer is not guaranteed, and the OS may free the pointer
early, particularly with OSSA. Push the handling into the closure to
ensure that the lifetime is extended for the duration.