TSCBasic: correct handling of normalizing relative paths #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative paths which are empty or `.` need to be handled as a special case as PathCanonicalizeW is meant to canonicalize absolute paths, and will convert these cases to the root of the current drive `\`. This enables a number of swift-driver tests to now pass on Windows.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
neonichu
approved these changes
Oct 14, 2021
tomerd
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative paths which are empty or
.need to be handled as a specialcase as PathCanonicalizeW is meant to canonicalize absolute paths, and
will convert these cases to the root of the current drive
\. Thisenables a number of swift-driver tests to now pass on Windows.