Remove LinuxMain.swift #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift 5.5+ Swift Package Manager warns that `--enable-test-discovery` is enabled by default. I assume for this project that should mean this isn't needed anymore on `main`.
keith
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
https://github.com/apple/swift-tools-support-core/blob/main/Package.swift#L1 needs to be updated to 5.4 to be able to remove this safely |
|
Updated. Is it just 5.4 or does it need to be 5.5? |
neonichu
approved these changes
Oct 29, 2021
|
@swift-ci please test |
5.4 is fine |
|
@swift-ci please test |
|
ci infra trouble? @swift-ci please test Linux |
tomerd
approved these changes
Oct 29, 2021
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5.5+ Swift Package Manager warns that
--enable-test-discoveryisenabled by default. I assume for this project that should mean this
isn't needed anymore on
main.