TSCBasic: properly track abnormal exits on Windows #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
The process handling did not properly account for abnormal process
termination. Unlike Unix platforms, Windows does not have a concept of
signals. However, a process may be terminated abnormally by means of an
exception. The exception code is then transliterated into the exit code
for the process. In most circumstances, the exit code for the process
in such a case is either a `NTSTATUS` or `HRESULT`. Accordingly, the
way to detect the exception is to check the severity code of the
exception. The `HRESULT` and `NTSTATUS` codes are similarly structured:
~~~
1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|S|R|C|N|X|F A C I L I T Y |C O D E |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
S: Severity; If set, indicates a failure result. If clear, indicates a success result.
R: Reserved; If N is clear, this bit MUST be set to 0.
C: Customer; If set, indicates that this a customer defined error code.
N: If set, indicates that the error code is a NTSTATUS value.
X: Reserved; MBZ
Facility: An indicator of the source of the error.
Code: The remainder of the error code.
~~~
We would previously only check for the top nibble being 0xC or 0xE.
However, a 0x8 value is also permissible and indicates a failure. Plumb
this through as an abnormal exit with the specified exception code.
|
@swift-ci please test |
neonichu
approved these changes
Dec 20, 2021
|
@compnerd please also create a cherry pick to 5.6 once merged |
tomerd
approved these changes
Dec 20, 2021
|
#272 is the cherry-pick for 5.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process handling did not properly account for abnormal process
termination. Unlike Unix platforms, Windows does not have a concept of
signals. However, a process may be terminated abnormally by means of an
exception. The exception code is then transliterated into the exit code
for the process. In most circumstances, the exit code for the process
in such a case is either a
NTSTATUSorHRESULT. Accordingly, theway to detect the exception is to check the severity code of the
exception. The
HRESULTandNTSTATUScodes are similarly structured:We would previously only check for the top nibble being 0xC or 0xE.
However, a 0x8 value is also permissible and indicates a failure. Plumb
this through as an abnormal exit with the specified exception code.