abstract SHA256 implementaiton differences behind a single implementation #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion motivation: reduce boilerplate on call sites changes: * rename the internal implementation of SHA256 to InternalSHA256 and make it internal * rename the CryptoKit implementation of SHA256 to _CryptoKitSHA256 and make it internal * create a public SHA256 that delegates to CryptoKit / Internal based on platform availability * mark CryptoKitSHA256 as deprecated encouraging users to move to the SHA256 abstraction * adjust and add tests
tomerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
Dec 22, 2021
tomerd
added
the
ready
abertelrud
approved these changes
Dec 22, 2021
|
Besides the other advantages it seems that this could be good for performance, assuming that the system implementation is heavily optimized. Nice! |
|
@swift-ci test |
|
@swift-ci test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: reduce boilerplate on call sites
changes: