[Triple] More detailed errors if getting the triple from the compiler should fail #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karwa
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
compnerd
approved these changes
Jan 13, 2022
|
@swift-ci please test |
|
Yeah the comments are mostly just to break up what would otherwise be an unreadable glob of do-catches. They could also be blank lines, I suppose. |
neonichu
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails spuriously on Windows. It would be nice to get some more detailed output when that happens, and it's probably a useful thing for other platforms, too.
CC @compnerd