deprecate global and process verbosity #290
Conversation
tomerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
afaict this is only used by SwiftPM, which is addressed in swiftlang/swift-package-manager#4109 |
|
swiftlang/swift-package-manager#4109 @swift-ci please test |
Sources/TSCBasic/Process.swift
Outdated
| Self.loggingHandler != nil | ||
| } | ||
|
|
||
| public static var loggingHandler: ((String) -> Void)? = nil |
There was a problem hiding this comment.
not in love with this static, but it is useful to be able to set this globally in SwiftPM instead of on every process invocation. open to other ideas and opinions
There was a problem hiding this comment.
yea i think i am going to just remove it and let the clients deal with setting a handler at the instance call site level. they can always create their own wrapper
There was a problem hiding this comment.
sounds good, you can also always use a lock... but it doesn't seem like a great idea anyway
There was a problem hiding this comment.
yea, I dont like this global pattern anyway. lets see how much hassle it is to do it instance level in SwiftPM
There was a problem hiding this comment.
ugh. its quite a bit of a hassle unfortunately. I added lock for now. @weissi :/ ptal
|
swiftlang/swift-package-manager#4109 @swift-ci please test |
3 similar comments
|
swiftlang/swift-package-manager#4109 @swift-ci please test |
|
swiftlang/swift-package-manager#4109 @swift-ci please test |
|
swiftlang/swift-package-manager#4109 @swift-ci please test |
| stdoutStream <<< arguments.map({ $0.spm_shellEscaped() }).joined(separator: " ") <<< "\n" | ||
| stdoutStream.flush() | ||
| if let loggingHandler = self.loggingHandler { | ||
| loggingHandler(arguments.map({ $0.spm_shellEscaped() }).joined(separator: " ")) |
There was a problem hiding this comment.
not any more, it was for the stream itself. the handler will decide what to do with it now
tomerd
force-pushed
the
refactor/verbosity
branch
from
7c44b2d to
c282b4a
Compare
motivation: fine grained control over verbosity setting and handling of logging changes: * deprecate global verbosity flag * deprecate Process verbosity attribute in favor of an optional logging handler (closure)
tomerd
force-pushed
the
refactor/verbosity
branch
from
c282b4a to
a79476b
Compare
|
@swift-ci please test |
motivation: fine grained control over verbosity setting and handling of logging
changes: