TSCUtility: deprecate dl* #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark the dl* helper functions as deprecated. There currently is a singular user of these functions - swift-driver. swift-driver is able to host the functions for the proper handling of the shared library loading/unloading and symbol lookup.
compnerd
requested review from
aciidgh,
abertelrud,
neonichu and
friedbunny
as code owners
|
CC: @artemcm |
|
@swift-ci please test |
tomerd
approved these changes
Feb 12, 2022
stevapple
pushed a commit
to stevapple/swift-tools-support-core
that referenced
this pull request
Mar 1, 2022
On this platform, the TIOCGWINSZ ioctl identifier is a complex macro. Since we don't have a C bridging header obviously available to get the flattened value, supply is the flattened value obtained elsewhere. This is of course brittle but this is the simplest way around this for now. Compare swiftlang#291 in swift-argument-parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the dl* helper functions as deprecated. There currently is a
singular user of these functions - swift-driver. swift-driver is able
to host the functions for the proper handling of the shared library
loading/unloading and symbol lookup.