TSCBasic: rework relative path construction on Windows #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constructing a path relative to a root, compose the final path before canonicalization as the canonicalization may require lookups in the base location. We additionally pay a small penalty to convert the slashes to native separators. This is purely for aesthetic purposes, it ensures that the path is computed initially rather than delayed until use. This in conjunction with swiftlang/swift-package-manager#4237 enables the use of header search paths in SPM which are based in other targets.
compnerd
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
cc @tomerd This is the second part of the fix in swiftlang/swift-package-manager#4237 |
|
@swift-ci please test |
tomerd
approved these changes
Mar 19, 2022
compnerd
added a commit
to compnerd/swift-tools-support-core
that referenced
this pull request
Apr 1, 2022
When constructing a path relative to a root, compose the final path before canonicalization as the canonicalization may require lookups in the base location. We additionally pay a small penalty to convert the slashes to native separators. This is purely for aesthetic purposes, it ensures that the path is computed initially rather than delayed until use. This in conjunction with swiftlang/swift-package-manager#4237 enables the use of header search paths in SPM which are based in other targets.
abertelrud
pushed a commit
that referenced
this pull request
Apr 4, 2022
When constructing a path relative to a root, compose the final path before canonicalization as the canonicalization may require lookups in the base location. We additionally pay a small penalty to convert the slashes to native separators. This is purely for aesthetic purposes, it ensures that the path is computed initially rather than delayed until use. This in conjunction with swiftlang/swift-package-manager#4237 enables the use of header search paths in SPM which are based in other targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing a path relative to a root, compose the final path
before canonicalization as the canonicalization may require lookups
in the base location.
We additionally pay a small penalty to convert the slashes to native
separators. This is purely for aesthetic purposes, it ensures that the
path is computed initially rather than delayed until use.
This in conjunction with swiftlang/swift-package-manager#4237 enables the
use of header search paths in SPM which are based in other targets.