Implement custom equatable for Triple
#307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
aciidgh,
abertelrud,
friedbunny and
tomerd
as code owners
|
@swift-ci please test |
neonichu
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Mar 29, 2022
In swiftlang/swift-tools-support-core#300, I made `Triple` more lenient w.r.t. different spellings of macOS. Since we are using string matching for finding matching binary artifacts, that would break with differently spelled triples. This PR in conjunction with swiftlang/swift-tools-support-core#307 ensures that we are finding artifacts based on the parsed representation of triples, not their string representations.
|
This makes sense to me, and I suspect it was just an oversight to include the original string through synthesis. |
abertelrud
approved these changes
Mar 29, 2022
It seems like equality for triples should depend on the parsed version and exclude the initial string representation. Eventually, we should probably get rid of storing the original string and compute that from the parsed version, but I am just trying to address equality for now.
neonichu
force-pushed
the
triple-equatable
branch
from
8e4d722 to
1782a8e
Compare
|
@swift-ci please test |
neonichu
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 1, 2022
In swiftlang/swift-tools-support-core#300, I made `Triple` more lenient w.r.t. different spellings of macOS. Since we are using string matching for finding matching binary artifacts, that would break with differently spelled triples. This PR in conjunction with swiftlang/swift-tools-support-core#307 ensures that we are finding artifacts based on the parsed representation of triples, not their string representations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like equality for triples should depend on the parsed version and exclude the initial string representation.
Eventually, we should probably get rid of storing the original string and compute that from the parsed version, but I am just trying to address equality for now.