TSCBasic: alter environment handling for Windows #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using the unicode environment, which should be preferred, use the ANSI environment operations. This is important to do here as the reading of the environment relies on Foundation, which in turn relies on CoreFoundation for `_CFEnviron` which returns the ANSI environment. As a result, we need to ensure that we use the ANSI environment variables through out as the C runtime will maintain the two environments in parallel and may go out of sync. This will enable additional tests in Swift Package Manager to pass on Windows, but should really be addressed by changing Foundation to use the Unicode environment variables and then using that once more here.
compnerd
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
@swift-ci please test |
neonichu
approved these changes
May 11, 2022
😱 |
|
@compnerd is there a unit test we can add here? |
|
Likely; however, it would be of little value - t-s-c tests don't run on windows yet. This actually was something that was caught through the SPM test suite. https://github.com/apple/swift-tools-support-core/blob/main/Tests/TSCBasicTests/ProcessEnvTests.swift |
tomerd
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using the unicode environment, which should be preferred,
use the ANSI environment operations. This is important to do here as
the reading of the environment relies on Foundation, which in turn
relies on CoreFoundation for
_CFEnvironwhich returns the ANSIenvironment. As a result, we need to ensure that we use the ANSI
environment variables through out as the C runtime will maintain the two
environments in parallel and may go out of sync.
This will enable additional tests in Swift Package Manager to pass on
Windows, but should really be addressed by changing Foundation to use
the Unicode environment variables and then using that once more here.