TSCBasic: special case a few leading character cases for Path #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UNIX implementation special cases `/` and `~` which SPM depends on. Handle the invalid file system character `~` specially on Windows as well. As we are now getting closer to normalized path spellings, we need to add a special case for the leading path separator character. On UNIX, this signifies the root of the singular unified file system view. However, Windows presents a forest to the user with 26 roots. Consequently, a path headed by the path separator is a relative path rather than an absolute path. However, we treat the root-relative path as an invalid relative path for the time being as the representation is not flexible enough to account for this model.
compnerd
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
@swift-ci please test |
neonichu
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UNIX implementation special cases
/and~which SPM depends on.Handle the invalid file system character
~specially on Windows aswell. As we are now getting closer to normalized path spellings, we
need to add a special case for the leading path separator character. On
UNIX, this signifies the root of the singular unified file system view.
However, Windows presents a forest to the user with 26 roots.
Consequently, a path headed by the path separator is a relative path
rather than an absolute path. However, we treat the root-relative path
as an invalid relative path for the time being as the representation is
not flexible enough to account for this model.