Skip to content

make lock lock&unlock methods public for process migration to spm #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Overcot
Copy link
Contributor

@Overcot Overcot commented Jun 8, 2022

As mentioned in swiftlang/swift-package-manager#5532 (comment) there is a need to migrate some bits of Process to spm and in order to do that the Lock.lock and Lock.unlock are needed to be public

@tomerd
Copy link
Contributor

tomerd commented Jun 8, 2022

thanks @Overcot, since this is just a simple wrapper of NSLock, maybe we move it whole sale into SwiftPM Basics module?

@Overcot
Copy link
Contributor Author

Overcot commented Jun 8, 2022

thanks @Overcot, since this is just a simple wrapper of NSLock, maybe we move it whole sale into SwiftPM Basics module?

Yes, i can do it. But would i need to remove the wrapper inside TSCBasic or leave it as it is?

@tomerd
Copy link
Contributor

tomerd commented Jun 8, 2022

Yes, i can do it. But would i need to remove the wrapper inside TSCBasic or leave it as it is?

I suggest we leave it in, and put a @available(*, deprecated) on top of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants