Skip to content

[5.7] Always parse the ABI component of target triples #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neonichu
Copy link
Contributor

5.7 cherry-pick of #330

Previously, we were ignoring the ABI component unless it started with the literal string "android". This seems incorrect, we should be including any type of ABI component if it is present in a triple.

(cherry picked from commit 710b623)
@neonichu neonichu added the swift 5.7 This PR targets the 5.7 branch label Jun 23, 2022
@neonichu neonichu requested a review from airspeedswift June 23, 2022 19:09
@neonichu neonichu self-assigned this Jun 23, 2022
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu neonichu merged commit ab1bb8a into swiftlang:release/5.7 Jun 27, 2022
@neonichu neonichu deleted the always-parse-abi-in-triple-5.7 branch June 27, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swift 5.7 This PR targets the 5.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants