TSCBasic: correct resolvingSymlinks on Windows
#347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is not meant to resolve a symbolic link in the terminal arc but rather anywhere along the path. More specifically, it is meant to behave similar to `realpath` on Unix. The moral equivalent operation on Windows is `GetFinalPathNameByHandle` which takes a handle to the file and retrieves the actual location resolving any junctions in the path. This repairs the behaviour of the function which is important for SourceKit-LSP's test suite.
compnerd
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
@swift-ci please test |
neonichu
approved these changes
Aug 19, 2022
tomerd
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is not meant to resolve a symbolic link in the terminal arc
but rather anywhere along the path. More specifically, it is meant to
behave similar to
realpathon Unix. The moral equivalent operation onWindows is
GetFinalPathNameByHandlewhich takes a handle to the fileand retrieves the actual location resolving any junctions in the path.
This repairs the behaviour of the function which is important for
SourceKit-LSP's test suite.