Skip to content

Fix tests on macOS 13 #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

Fix tests on macOS 13 #354

merged 1 commit into from
Oct 20, 2022

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Oct 14, 2022 •
edited
Loading

Python is no longer installed in /usr/bin, so support /usr/local as well. In the medium term, we should not depend on Python for these tests.

@neonichu neonichu self-assigned this Oct 14, 2022
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author 

[295/295] Testing TSCUtilityTests.ProgressAnimationTests/testNinjaProgressAnimationDumbTerminal
Test Suite 'Selected tests' started at 2022-10-14 18:51:14.028Test Suite 'FileSystemTests' started at 2022-10-14 18:51:14.029Test Case 'FileSystemTests.testLocalReadWriteFile' started at 2022-10-14 18:51:14.029/home/build-user/swift-tools-support-core/Tests/TSCBasicTests/FileSystemTests.swift:340: error: FileSystemTests.testLocalReadWriteFile : XCTAssertEqual failed: ("FileSystemError(kind: TSCBasic.FileSystemError.Kind.isDirectory, path: Optional(<AbsolutePath:"/">))") is not equal to ("FileSystemError(kind: TSCBasic.FileSystemError.Kind.ioError(code: 17), path: Optional(<AbsolutePath:"/">))") -Test Case 'FileSystemTests.testLocalReadWriteFile' failed (0.114 seconds)Test Suite 'FileSystemTests' failed at 2022-10-14 18:51:14.143

Interesting, looks like this failure actually isn't macOS 13 specific but also happening on the Linux CI?

@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

I think I am going to undo the FileSystemError part of this, not sure why it fails sometimes, but it doesn't necessarily seem to be related to the host OS.

@neonichu neonichu force-pushed the fix-tests-on-ventura branch from fece6dd to 8dc6e95 Compare October 19, 2022 20:33
@neonichu
Copy link
Contributor Author

@swift-ci please test

tomerd
tomerd approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion

@neonichu neonichu force-pushed the fix-tests-on-ventura branch from 8dc6e95 to c5f8abf Compare October 20, 2022 19:11
@neonichu
Fix tests on macOS 13
febd475 
Python is no longer installed in `/usr/bin`, so support `/usr/local` as well. In the medium term, we should not depend on Python for these tests.
@neonichu neonichu force-pushed the fix-tests-on-ventura branch from c5f8abf to febd475 Compare October 20, 2022 19:13
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu neonichu merged commit 301d475 into swiftlang:main Oct 20, 2022
@neonichu neonichu deleted the fix-tests-on-ventura branch October 20, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@abertelrud abertelrud Awaiting requested review from abertelrud

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neonichu @tomerd