TSCBasic: mark Path-conforming types Sendable
#361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
@swift-ci please test |
neonichu
approved these changes
Nov 3, 2022
MaxDesiatov
added a commit
that referenced
this pull request
Nov 3, 2022
SwiftPM already requires 5.5, but now with `Sendable` introduced on some TSC types in #361, this is unlikely to compile without errors with Swift 5.4.
neonichu
pushed a commit
that referenced
this pull request
Nov 7, 2022
SwiftPM already requires 5.5, but now with `Sendable` introduced on some TSC types in #361, this is unlikely to compile without errors with Swift 5.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types only have a trivial
Stringstored property in their implementation. Marking them asSendableseems safe and allows them to be freely used inasynccontexts.