Basic: handle root checking on Windows more properly #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roots on Windows are more complicated. The drive name is not considered a root, but is a root for the Path API as you can not go any further. It is however a name and not a path, therefore it is not a root path. Use that alongwith `PathCchIsRootW` to classify the paths on Windows as being a root or not.
aciidgh
approved these changes
Feb 26, 2020
|
@swift-ci smoke test |
|
@swift-ci test |
|
@compnerd should we continue to work on this in light of recent discussions? |
|
The current changes required to bootstrap are in #114. This should is considered obsoleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roots on Windows are more complicated. The drive name is not considered
a root, but is a root for the Path API as you can not go any further.
It is however a name and not a path, therefore it is not a root path.
Use that alongwith
PathCchIsRootWto classify the paths on Windows asbeing a root or not.