Skip to content

[FileSystem] Throw "unsupported" rather than fatalError()'ing #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020
Merged

[FileSystem] Throw "unsupported" rather than fatalError()'ing #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/TSCBasic/FileSystem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ public extension FileSystem {
}

func getFileInfo(_ path: AbsolutePath) throws -> FileInfo {
fatalError("This file system currently doesn't support this method")
throw FileSystemError.unsupported
}
}

Expand Down Expand Up @@ -578,7 +578,7 @@ public class InMemoryFileSystem: FileSystem {
}

public func changeCurrentWorkingDirectory(to path: AbsolutePath) throws {
fatalError("Unsupported")
throw FileSystemError.unsupported
}

public var homeDirectory: AbsolutePath {
Expand Down Expand Up @@ -812,7 +812,7 @@ public class RerootedFileSystemView: FileSystem {
}

public func changeCurrentWorkingDirectory(to path: AbsolutePath) throws {
fatalError("Unsupported")
throw FileSystemError.unsupported
}

public var homeDirectory: AbsolutePath {
Expand Down