Fix search for the Swift compiler on Windows #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
egorzhdan
force-pushed
the
master
branch
2 times, most recently
from
6ea0ce0 to
a8f3e36
Compare
|
@compnerd would you be able to help drive this PR per your recent work on the topic |
compnerd
reviewed
Aug 18, 2020
compnerd
reviewed
Aug 18, 2020
Sources/TSCLibc/libc.swift
Outdated
| } | ||
| return String(cString: result).withCStringW { resultW, capacity in | ||
| return path.withCStringW { pathW, _ in | ||
| guard _wfullpath(UnsafeMutablePointer(mutating: resultW), pathW, capacity) != nil else { |
There was a problem hiding this comment.
I don't think that this is really the equivalent to realpath btw, this will expand the relative paths but I don't think it will resolve symlinks along the way.
|
I've excluded the changes in |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
Path.isAbsoluteimplementation isn't valid for Windows paths, SwiftPM tries to find the Swift compiler in paths like this:while the actual path is:
After this change SwiftPM can successfully find
swiftc.exeon Windows, create a temporary directory for the artifacts and run the compiler (which currently results in an unrelated error).