Skip to content

Commit 01f9fdc

Browse files
authored
Merge pull request #19634 from jrose-apple/looking-backwards
2 parents d2fabf9 + c4c430e commit 01f9fdc

8 files changed

+28
-3
lines changed

test/SILGen/tsan_instrumentation.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
// RUN: %target-swift-emit-silgen -sanitize=thread %s | %FileCheck %s
22
// REQUIRES: tsan_runtime
33

4+
// FIXME: This should be covered by "tsan_runtime"; older versions of Apple OSs
5+
// don't support TSan.
6+
// UNSUPPORTED: remote_run
7+
48
func takesInout(_ p: inout Int) { }
59
func takesInout(_ p: inout MyStruct) { }
610

test/Sanitizers/tsan-norace-block-release.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
// REQUIRES: objc_interop
66
// REQUIRES: tsan_runtime
77

8+
// FIXME: This should be covered by "tsan_runtime"; older versions of Apple OSs
9+
// don't support TSan.
10+
// UNSUPPORTED: remote_run
11+
812
// Test that we do not report a race on block release operation.
913
import Foundation
1014

test/Sanitizers/tsan-norace-deinit-run-time.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
// REQUIRES: objc_interop
66
// REQUIRES: tsan_runtime
77

8+
// FIXME: This should be covered by "tsan_runtime"; older versions of Apple OSs
9+
// don't support TSan.
10+
// UNSUPPORTED: remote_run
11+
812
// Test that we do not report a race on deinit; the synchronization is guaranteed by runtime.
913
import Foundation
1014

test/Sanitizers/tsan-static-exclusivity.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
// RUN: %target-swift-frontend -enforce-exclusivity=checked -sanitize=thread -emit-sil -primary-file %s -o /dev/null -verify
22
// REQUIRES: tsan_runtime
33

4+
// FIXME: This should be covered by "tsan_runtime"; older versions of Apple OSs
5+
// don't support TSan.
6+
// UNSUPPORTED: remote_run
7+
48

59
struct OtherStruct {
610
mutating

test/Sanitizers/tsan.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
// REQUIRES: tsan_runtime
66
// UNSUPPORTED: OS=tvos
77

8+
// FIXME: This should be covered by "tsan_runtime"; older versions of Apple OSs
9+
// don't support TSan.
10+
// UNSUPPORTED: remote_run
11+
812
// https://bugs.swift.org/browse/SR-6622
913
// XFAIL: linux
1014

test/stdlib/MapKit.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ func spansEqual(_ x: MKCoordinateSpan, _ y: MKCoordinateSpan)
2121

2222
if #available(tvOS 9.2, *) {
2323
mapKit.test("NSValue bridging")
24-
.skip(.iOSMinor(9, 3, reason: "<rdar://problem/41440036>")).code {
24+
.xfail(.iOSMinor(9, 3, reason: "<rdar://problem/41440036>"))
25+
.xfail(.osxMinorRange(10, 9...10, reason: "<rdar://problem/44866579>"))
26+
.code {
2527
expectBridgeToNSValue(CLLocationCoordinate2D(latitude: 17, longitude: 38),
2628
nsValueInitializer: { NSValue(mkCoordinate: $0) },
2729
nsValueGetter: { $0.mkCoordinateValue },

test/stdlib/SwiftObjectNSObject.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
// RUN: %target-clang %S/Inputs/SwiftObjectNSObject/SwiftObjectNSObject.m -c -o %t/SwiftObjectNSObject.o -g
1616
// RUN: %target-build-swift %s -I %S/Inputs/SwiftObjectNSObject/ -Xlinker %t/SwiftObjectNSObject.o -o %t/SwiftObjectNSObject
1717
// RUN: %target-codesign %t/SwiftObjectNSObject
18-
// RUN: %target-run %t/SwiftObjectNSObject 2>&1 | %FileCheck %s
18+
// RUN: %target-run %t/SwiftObjectNSObject 2> %t/log.txt
19+
// RUN: %FileCheck %s < %t/log.txt
1920
// REQUIRES: executable_test
2021

2122
// REQUIRES: objc_interop

test/stdlib/TestLocale.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,9 @@ class TestLocale : TestLocaleSuper {
9494

9595
expectEqual(".", locale.decimalSeparator)
9696
expectEqual(",", locale.groupingSeparator)
97-
expectEqual("HK$", locale.currencySymbol)
97+
if #available(macOS 10.11, *) {
98+
expectEqual("HK$", locale.currencySymbol)
99+
}
98100
expectEqual("HKD", locale.currencyCode)
99101

100102
expectTrue(Locale.availableIdentifiers.count > 0)

0 commit comments

Comments
 (0)