More backwards-deployment test fixes #19634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally lit.cfg would conditionalize this based on the remote OS, but that's tricky. Meanwhile, let's not fail on old versions of Apple OSs that don't support TSan. rdar://problem/44802353
Part of rdar://problem/44866579. This bears further investigation.
remote-run doesn't always preserve the interleaving, but we don't need stdout at all given what's being checked; it's just used to show how far the test got before failing. The output being FileChecked is going through NSLog, which uses stderr. Part of rdar://problem/44866579
Apparently this changed at some point in the past (it used to just be "$"). The actual value isn't so important, so just skip that part. Part of rdar://problem/44866579
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak or disable a handful of tests when using remote-run to test on older OSs.
rdar://problem/44802353
rdar://problem/44866579