Merge pull request #64004 from artemcm/ConstExtractFixes

[Compile Time Constant Extraction] Look through Optional injection and underlying-to-opaque conversions

Author: swift-ci

lib/ConstExtract/ConstExtract.cpp

@@ -142,6 +142,8 @@ extractFunctionArguments(const ArgumentList *args) {
       if (decl->hasDefaultExpr()) {
         argExpr = decl->getTypeCheckedDefaultExpr();
       }
+    } else if (auto optionalInject = dyn_cast<InjectIntoOptionalExpr>(argExpr)) {
+      argExpr = optionalInject->getSubExpr();
     }
     parameters.push_back({label, type, extractCompileTimeValue(argExpr)});
   }
@@ -308,6 +310,30 @@ static std::shared_ptr<CompileTimeValue> extractCompileTimeValue(Expr *expr) {
       return std::make_shared<TypeValue>(dotSelfExpr->getType());
     }
 
+    case ExprKind::UnderlyingToOpaque: {
+      auto underlyingToOpaque = cast<UnderlyingToOpaqueExpr>(expr);
+      return extractCompileTimeValue(underlyingToOpaque->getSubExpr());
+    }
+
+    case ExprKind::DefaultArgument: {
+      auto defaultArgExpr = cast<DefaultArgumentExpr>(expr);
+      auto *decl = defaultArgExpr->getParamDecl();
+      // If there is a default expr, we should have looked through to it
+      assert(!decl->hasDefaultExpr());
+      switch (decl->getDefaultArgumentKind()) {
+      case DefaultArgumentKind::NilLiteral:
+        return std::make_shared<RawLiteralValue>("nil");
+      case DefaultArgumentKind::EmptyArray:
+        return std::make_shared<ArrayValue>(
+            std::vector<std::shared_ptr<CompileTimeValue>>());
+      case DefaultArgumentKind::EmptyDictionary:
+        return std::make_shared<DictionaryValue>(
+            std::vector<std::shared_ptr<TupleValue>>());
+      default:
+        break;
+      }
+    } break;
+
     default: {
       break;
     }

test/ConstExtraction/ExtractInjectOptional.swift

@@ -0,0 +1,35 @@
+// RUN: %empty-directory(%t)
+// RUN: echo "[MyProto]" > %t/protocols.json
+
+// RUN: %target-swift-frontend -typecheck -emit-const-values-path %t/ExtractLiterals.swiftconstvalues -const-gather-protocols-file %t/protocols.json -primary-file %s
+// RUN: cat %t/ExtractLiterals.swiftconstvalues 2>&1 | %FileCheck %s
+
+protocol MyProto {}
+struct InjectablePropertyStruct : MyProto {
+    let init1 = Bat(buz: "hello", fuz: 4)
+}
+
+public struct Bat {
+    let buz: String?
+    let fuz: Int
+
+    init(buz: String? = "", fuz: Int = 0) {
+        self.buz = buz
+        self.fuz = fuz
+    }
+}
+
+// CHECK:      "arguments": [
+// CHECK-NEXT: {
+// CHECK-NEXT:   "label": "buz",
+// CHECK-NEXT:   "type": "Swift.Optional<Swift.String>",
+// CHECK-NEXT:   "valueKind": "RawLiteral",
+// CHECK-NEXT:   "value": "hello"
+// CHECK-NEXT: },
+// CHECK-NEXT: {
+// CHECK-NEXT:   "label": "fuz",
+// CHECK-NEXT:   "type": "Swift.Int",
+// CHECK-NEXT:   "valueKind": "RawLiteral",
+// CHECK-NEXT:   "value": "4"
+// CHECK-NEXT: }
+// CHECK-NEXT: ]

test/ConstExtraction/ExtractUnderlyingToOpaque.swift

@@ -0,0 +1,36 @@
+// RUN: %empty-directory(%t)
+// RUN: echo "[MyProto]" > %t/protocols.json
+
+// RUN: %target-swift-frontend -typecheck -emit-const-values-path %t/ExtractLiterals.swiftconstvalues -const-gather-protocols-file %t/protocols.json -primary-file %s
+// RUN: cat %t/ExtractLiterals.swiftconstvalues 2>&1 | %FileCheck %s
+
+protocol MyProto {}
+protocol Bird {}
+
+@available(iOS 13, macOS 10.15, tvOS 13, watchOS 6, *)
+struct UnderlyingToOpaquePropertyStruct : MyProto {
+    @available(iOS 13, macOS 10.15, tvOS 13, watchOS 6, *)
+    var warbler: some Bird {
+        Warbler("blue")
+    }
+}
+
+public struct Warbler : Bird {
+    let belly: String = "yellow"
+    init(_ color: String = "red") {
+        self.belly = color
+    }
+}
+
+// CHECK:             "valueKind": "InitCall",
+// CHECK-NEXT:        "value": {
+// CHECK-NEXT:          "type": "ExtractUnderlyingToOpaque.Warbler",
+// CHECK-NEXT:          "arguments": [
+// CHECK-NEXT:            {
+// CHECK-NEXT:              "label": "",
+// CHECK-NEXT:              "type": "Swift.String",
+// CHECK-NEXT:              "valueKind": "RawLiteral",
+// CHECK-NEXT:              "value": "blue"
+// CHECK-NEXT:            }
+// CHECK-NEXT:          ]
+// CHECK-NEXT:        }