Skip to content

[Compile Time Constant Extraction] Look through Optional injection and underlying-to-opaque conversions #64004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Mar 1, 2023

InjectIntoOptionalExpr is an implicit cast that the extraction code may need to look through to get the underlying compile-time value.

Similarly, for computed properties of an opaque type, look through the UnderlyingToOpaqueExpr.

Resolves rdar://106059663
Resolves rdar://106006689

@artemcm
Copy link
Contributor Author

artemcm commented Mar 1, 2023

@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Mar 1, 2023

@swift-ci smoke test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Mar 1, 2023

@swift-ci smoke test and merge

@artemcm artemcm force-pushed the ConstExtractFixes branch from 9151c70 to 76b9281 Compare March 2, 2023 16:48
@artemcm
Copy link
Contributor Author

artemcm commented Mar 2, 2023

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 03b7ad6 into swiftlang:main Mar 2, 2023
@artemcm artemcm deleted the ConstExtractFixes branch March 2, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants