Merge pull request #61863 from LucianoPAlmeida/crash-dump-parse-init

[ASTDumper] Special handling for init kind in pre-typecheck dump

Author: LucianoPAlmeida

lib/AST/Decl.cpp

@@ -9089,6 +9089,20 @@ Type ConstructorDecl::getInitializerInterfaceType() {
 }
 
 CtorInitializerKind ConstructorDecl::getInitKind() const {
+  const auto *ED =
+      dyn_cast_or_null<ExtensionDecl>(getDeclContext()->getAsDecl());
+  if (ED && !ED->hasBeenBound()) {
+    // When the declaration context is an extension and this is called when the
+    // extended nominal hasn't be bound yet, e.g. dumping pre-typechecked AST,
+    // there is not enough information about extended nominal to use for
+    // computing init kind on InitKindRequest as bindExtensions is done at
+    // typechecking, so in that case just look to parsed attribute in init
+    // declaration.
+    return getAttrs().hasAttribute<ConvenienceAttr>()
+               ? CtorInitializerKind::Convenience
+               : CtorInitializerKind::Designated;
+  }
+
   return evaluateOrDefault(getASTContext().evaluator,
     InitKindRequest{const_cast<ConstructorDecl *>(this)},
     CtorInitializerKind::Designated);

validation-test/compiler_crashers_2_fixed/issue-61086.swift

@@ -0,0 +1,20 @@
+// RUN: %target-typecheck-verify-swift -dump-parse
+
+// https://github.com/apple/swift/issues/61806
+
+struct I61806 {}
+extension I61806 {
+  init() { }
+}
+
+class I61806_C { 
+  init() {}
+}
+extension I61806_C {
+  convenience init(a: Int) {}
+}
+
+protocol I61806_P {}
+extension I61806_P {
+ init() {}
+}