[ASTDumper] Special handling for init kind in pre-typecheck dump #61863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
LucianoPAlmeida
force-pushed
the
crash-dump-parse-init
branch
from
52c1fd8 to
8e7c164
Compare
|
@swift-ci Please smoke test |
LucianoPAlmeida
force-pushed
the
crash-dump-parse-init
branch
from
8e7c164 to
834d953
Compare
LucianoPAlmeida
force-pushed
the
crash-dump-parse-init
branch
from
834d953 to
70b884c
Compare
xedin
approved these changes
Dec 15, 2022
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my current understanding, when dumping
ConstructorDeclin pre-typechecked AST there is not enough information about extended nominal(as bindExtensions is done at typechecking) forgetInitKindwhich has rules based on that extended nominal to compute the kind, so in thatdump-parsecase, just look to parsed attribute in init declaration.Resolves #61806