Skip to content

Commit 158703c

Browse files
authored
Merge pull request #17772 from davezarzycki/fix_fall_through_warning
2 parents 99858b7 + a3d488a commit 158703c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

include/swift/AST/Ownership.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,22 +45,24 @@ enum : unsigned { NumReferenceOwnershipBits =
4545
static inline llvm::StringRef keywordOf(ReferenceOwnership ownership) {
4646
switch (ownership) {
4747
case ReferenceOwnership::Strong:
48-
assert(false && "not applicable");
48+
break;
4949
case ReferenceOwnership::Weak: return "weak";
5050
case ReferenceOwnership::Unowned: return "unowned";
5151
case ReferenceOwnership::Unmanaged: return "unowned(unsafe)";
5252
}
53+
// We cannot use llvm_unreachable() because this is used by the stdlib.
5354
assert(false && "impossible");
5455
}
5556

5657
static inline llvm::StringRef manglingOf(ReferenceOwnership ownership) {
5758
switch (ownership) {
5859
case ReferenceOwnership::Strong:
59-
assert(false && "not applicable");
60+
break;
6061
case ReferenceOwnership::Weak: return "Xw";
6162
case ReferenceOwnership::Unowned: return "Xo";
6263
case ReferenceOwnership::Unmanaged: return "Xu";
6364
}
65+
// We cannot use llvm_unreachable() because this is used by the stdlib.
6466
assert(false && "impossible");
6567
}
6668

0 commit comments

Comments
 (0)