Skip to content

[AST] NFC: Avoid fall through warnings in non-assert builds #17772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2018
Merged

[AST] NFC: Avoid fall through warnings in non-assert builds #17772

merged 1 commit into from
Jul 5, 2018

Conversation

davezarzycki
Copy link
Contributor

No description provided.

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test and merge

@davezarzycki davezarzycki mentioned this pull request Jul 5, 2018
Closed
airspeedswift
airspeedswift approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@airspeedswift airspeedswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I'm not totally up with the front-end code idioms.

@davezarzycki
Copy link
Contributor Author

I'm happy to commit style/convention/idiomatic fixes as they are pointed out.

@swift-ci swift-ci merged commit 158703c into swiftlang:master Jul 5, 2018
@davezarzycki davezarzycki deleted the fix_fall_through_warning branch July 5, 2018 23:02
@airspeedswift
Copy link
Member

Looks like all this did was substitute one warning for another.

./swift/include/swift/AST/Ownership.h:55:1: warning: control may reach end of non-void function [-Wreturn-type]
}
^
./include/swift/AST/Ownership.h:67:1: warning: control may reach end of non-void function [-Wreturn-type]
}
^

@davezarzycki
Copy link
Contributor Author

Thanks @airspeedswift – I'll open a pull request shortly.

@davezarzycki
Copy link
Contributor Author

Please see #17795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davezarzycki @airspeedswift @swift-ci