Skip to content

[AST] NFC: Avoid fall through warnings in non-assert builds #17772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2018
Merged

[AST] NFC: Avoid fall through warnings in non-assert builds #17772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/swift/AST/Ownership.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,24 @@ enum : unsigned { NumReferenceOwnershipBits =
static inline llvm::StringRef keywordOf(ReferenceOwnership ownership) {
switch (ownership) {
case ReferenceOwnership::Strong:
assert(false && "not applicable");
break;
case ReferenceOwnership::Weak: return "weak";
case ReferenceOwnership::Unowned: return "unowned";
case ReferenceOwnership::Unmanaged: return "unowned(unsafe)";
}
// We cannot use llvm_unreachable() because this is used by the stdlib.
assert(false && "impossible");
}

static inline llvm::StringRef manglingOf(ReferenceOwnership ownership) {
switch (ownership) {
case ReferenceOwnership::Strong:
assert(false && "not applicable");
break;
case ReferenceOwnership::Weak: return "Xw";
case ReferenceOwnership::Unowned: return "Xo";
case ReferenceOwnership::Unmanaged: return "Xu";
}
// We cannot use llvm_unreachable() because this is used by the stdlib.
assert(false && "impossible");
}

Expand Down