Merge pull request #72564 from Mayank-84/refactor/SIL/Effects

eeckstein · web-flow · commit 1a0bcb275480 · 2024-03-27T10:56:19.000+01:00
[Minor][SIL] Refactor `matches` function in `Effects`
diff --git a/SwiftCompilerSources/Sources/SIL/Effects.swift b/SwiftCompilerSources/Sources/SIL/Effects.swift
@@ -350,10 +350,7 @@ public struct EscapeEffects : CustomStringConvertible, NoReflectionChildren {
     }
 
     public func matches(_ rhsArgIdx: Int, _ rhsPath: SmallProjectionPath) -> Bool {
-      if argumentIndex != rhsArgIdx {
-        return false
-      }
-      return rhsPath.matches(pattern: pathPattern)
+      return argumentIndex == rhsArgIdx && rhsPath.matches(pattern: pathPattern)
     }
 
     public var bodyDescription: String {

Original file line number	Diff line number	Diff line change
`@@ -350,10 +350,7 @@ public struct EscapeEffects : CustomStringConvertible, NoReflectionChildren {`
`350`	`350`	`}`
`351`	`351`
`352`	`352`	`public func matches(_ rhsArgIdx: Int, _ rhsPath: SmallProjectionPath) -> Bool {`
`353`		`- if argumentIndex != rhsArgIdx {`
`354`		`- return false`
`355`		`- }`
`356`		`- return rhsPath.matches(pattern: pathPattern)`
	`353`	`+ return argumentIndex == rhsArgIdx && rhsPath.matches(pattern: pathPattern)`
`357`	`354`	`}`
`358`	`355`
`359`	`356`	`public var bodyDescription: String {`