[Minor][SIL] Refactor matches function in Effects
#72564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eeckstein, I see that we can follow latest swift syntaxes like shorter versions of if-let, etc at multiple places. Wanted to understand why are we not using this within these files? Are there any constraints related to CI or any platform versions that it is supporting? |
The only constraint is that It should be buildable with swift 5.9 (or later). If that's the case we can change to the newer syntax. |
|
@eeckstein Can you trigger the smoke test CI pipeline? I guess it is not accessible to me. |
|
@swift-ci test |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchesfunction.