Skip to content

Commit 2308bb1

Browse files
authored
Add _getMetadataSection{,Count,Name} to API digester allow list (#33138)
These APIs are needed to build SwiftReflectionTest.swift when testing Release builds. This rolls back 014918c, which hid these APIs in non-asserts builds causing a failure: https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/5708/consoleText rdar://66103895
1 parent 413bbab commit 2308bb1

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

stdlib/public/core/Misc.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ public func _getTypeByMangledNameInContext(
134134
genericArguments: UnsafeRawPointer?)
135135
-> Any.Type?
136136

137-
#if INTERNAL_CHECKS_ENABLED
138137
@_silgen_name("swift_getMetadataSection")
139138
public func _getMetadataSection(
140139
_ index: UInt)
@@ -148,4 +147,3 @@ public func _getMetadataSectionCount()
148147
public func _getMetadataSectionName(
149148
_ metadata_section: UnsafeRawPointer)
150149
-> UnsafePointer<CChar>
151-
#endif

test/api-digester/stability-stdlib-abi-with-asserts.test

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,3 @@ Struct _ObjectRuntimeFunctionCountersState is a new API without @available attri
3939
Struct _RuntimeFunctionCounters is a new API without @available attribute
4040
Func _swift_isImmutableCOWBuffer(_:) is a new API without @available attribute
4141
Func _swift_setImmutableCOWBuffer(_:_:) is a new API without @available attribute
42-
Func _getMetadataSection(_:) is a new API without @available attribute
43-
Func _getMetadataSectionCount() is a new API without @available attribute
44-
Func _getMetadataSectionName(_:) is a new API without @available attribute

test/api-digester/stability-stdlib-abi-without-asserts.test

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,8 @@
3030

3131
Func _prespecialize() is a new API without @available attribute
3232
Func _stdlib_isOSVersionAtLeastOrVariantVersionAtLeast(_:_:_:_:_:_:) is a new API without @available attribute
33+
34+
// These reflection APIs are exposed to facilitate building SwiftReflectionTest.swift when testing Release builds.
35+
Func _getMetadataSection(_:) is a new API without @available attribute
36+
Func _getMetadataSectionCount() is a new API without @available attribute
37+
Func _getMetadataSectionName(_:) is a new API without @available attribute

0 commit comments

Comments
 (0)