Add _getMetadataSection{,Count,Name} to API digester allow list

[vedantk]

These APIs facilitate building SwiftReflectionTest.swift when testing Release builds.

rdar://66103895

[vedantk]

@swift-ci smoke test

[vedantk]

cc @augusto2112 @adrian-prantl @brentdax

[vedantk]

See non-asserts build failure here: https://ci.swift.org/job/oss-swift-package-osx/5007/consoleText

[augusto2112]

@vedantk I think this will fail to build in Linux release builds, because of the SwiftReflectionTest.swift, which refers to those symbols, is built even on release (which was the reason I had to leave the symbols in release builds in the first place). Possible solutions would be:

• Change the stability-stdlib-abi-without-asserts.test like we did stability-stdlib-abi-with-asserts.test
• In SwiftReflectionTest.swiftcheck for INTERNAL_CHECKS_ENABLED, and if not, have dummy implementations of getReflectionInfoForImage and getImageCount
• Change the CMakeLists so SwiftReflectionTest.swift isn't built on release in Linux after all.

[vedantk]

@swift-ci smoke test

[vedantk]

git: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!

[vedantk]

@swift-ci smoke test OS X platform

[augusto2112]

@vedantk it seems like someone added that #if INTERNAL_CHECKS_ENABLED check, but that indeed broke it when stdlib assertions are off (see here). Maybe you could remove that in your PR since you're solving the same issue?

[augusto2112]

Also, I'm not sure why it's failing to build on OS X now. It looks like stability-stdlib-abi-with-asserts.test is complaining that we added the 3 functions for some reason?

There are these two lines in stability-stdlib-abi-with-asserts.test:

// RUN: %clang -E -P -x c %S/stability-stdlib-abi-without-asserts.test -o - > %t.tmp/stability-stdlib-abi.swift.expected
// RUN: %clang -E -P -x c %S/stability-stdlib-abi-with-asserts.test -o - >> %t.tmp/stability-stdlib-abi.swift.expected

My guess is that we're adding our functions twice to the list, and that's why it's failing (I'm not 100% sure on this though)

[vedantk]

It looks @natecook1000 and I both tried to address the issue by removing these APIs in non-asserts builds (Nate's change is 014918c).

[vedantk]

@swift-ci smoke test

[vedantk]

@swift-ci smoke test