Skip to content

Commit 260b6a1

Browse files
authored
Merge pull request #32409 from CodaFi/fixing-a-whole-where-the-rain-gets-in
Build Module Interfaces in WMO
2 parents d54aa5d + 0ca2399 commit 260b6a1

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

include/swift/Frontend/ModuleInterfaceLoader.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ struct InterfaceSubContextDelegateImpl: InterfaceSubContextDelegate {
244244
llvm::StringSaver ArgSaver;
245245
std::vector<StringRef> GenericArgs;
246246
CompilerInvocation subInvocation;
247-
std::vector<SupplementaryOutputPaths> ModuleOutputPaths;
248247

249248
template<typename ...ArgTypes>
250249
InFlightDiagnostic diagnose(StringRef interfacePath,

lib/Frontend/ModuleInterfaceLoader.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,7 +1349,7 @@ bool InterfaceSubContextDelegateImpl::runInSubCompilerInstance(StringRef moduleN
13491349
assert(BuildArgs.size() == GenericArgs.size());
13501350
// Configure inputs
13511351
subInvocation.getFrontendOptions().InputsAndOutputs
1352-
.addPrimaryInputFile(interfacePath);
1352+
.addInputFile(interfacePath);
13531353
BuildArgs.push_back(interfacePath);
13541354
subInvocation.setModuleName(moduleName);
13551355
BuildArgs.push_back("-module-name");
@@ -1366,13 +1366,12 @@ bool InterfaceSubContextDelegateImpl::runInSubCompilerInstance(StringRef moduleN
13661366
}
13671367

13681368
// Configure the outputs in front-end options. There must be an equal number of
1369-
// primary inputs and outputs.
1370-
auto N = subInvocation.getFrontendOptions().InputsAndOutputs
1371-
.primaryInputCount();
1372-
std::vector<std::string> outputFiles(N, "/<unused>");
1369+
// inputs and outputs.
1370+
std::vector<std::string> outputFiles{"/<unused>"};
1371+
std::vector<SupplementaryOutputPaths> ModuleOutputPaths;
13731372
ModuleOutputPaths.emplace_back();
13741373
ModuleOutputPaths.back().ModuleOutputPath = outputPath.str();
1375-
assert(N == ModuleOutputPaths.size());
1374+
assert(subInvocation.getFrontendOptions().InputsAndOutputs.isWholeModule());
13761375
subInvocation.getFrontendOptions().InputsAndOutputs
13771376
.setMainAndSupplementaryOutputs(outputFiles, ModuleOutputPaths);
13781377

0 commit comments

Comments
 (0)