Skip to content

Build Module Interfaces in WMO #32409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jun 16, 2020

Building in incremental mode incurs the overhead associated with the
incremental dependency tracking infrastructure. Considering we're
throwing away all of this stuff anyways, let's just build in WMO to
avoid that.

Building in incremental mode incurs the overhead associated with the
incremental dependency tracking infrastructure. Considering we're
throwing away all of this stuff anyways, let's just build in WMO to
avoid that.
@CodaFi CodaFi requested a review from nkcsgexi June 16, 2020 18:50
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 16, 2020

@swift-ci test

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 16, 2020

@swift-ci test source compatibility

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0ca2399

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 16, 2020

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0ca2399

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 16, 2020

Boy, I'm hitting everything today

@swift-ci test macOS

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 17, 2020

@CodaFi CodaFi merged commit 260b6a1 into swiftlang:master Jun 17, 2020
@CodaFi CodaFi deleted the fixing-a-whole-where-the-rain-gets-in branch June 17, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants