Merge pull request #11048 from CodaFi/optional-illusion

[NFC] Adjust return type of getTypeOfExpressionWithoutApplying

Author: CodaFi

lib/Sema/CSDiag.cpp

@@ -4651,9 +4651,9 @@ static bool diagnoseImplicitSelfErrors(Expr *fnExpr, Expr *argExpr,
       ConcreteDeclRef ref = nullptr;
       auto typeResult =
         TC.getTypeOfExpressionWithoutApplying(el, CS.DC, ref);
-      if (!typeResult.hasValue())
+      if (!typeResult)
         return false;
-      elts.push_back(typeResult.getValue());
+      elts.push_back(typeResult);
     }
 
     argType = TupleType::get(elts, CS.getASTContext());
@@ -6389,12 +6389,12 @@ bool FailureDiagnosis::visitApplyExpr(ApplyExpr *callExpr) {
              "unexpected declaration reference");
 
       ConcreteDeclRef decl = nullptr;
-      Optional<Type> type = CS.TC.getTypeOfExpressionWithoutApplying(
+      Type type = CS.TC.getTypeOfExpressionWithoutApplying(
           fnExpr, CS.DC, decl, FreeTypeVariableBinding::UnresolvedType,
           &listener);
 
-      if (type.hasValue())
-        fnType = getFuncType(type.getValue());
+      if (type)
+        fnType = getFuncType(type);
     } else {
       fnExpr = typeCheckChildIndependently(callExpr->getFn(), Type(),
                                            CTP_CalleeResult, TCC_ForceRecheck,
@@ -7338,7 +7338,7 @@ bool FailureDiagnosis::diagnoseClosureExpr(
       auto type = CS.TC.getTypeOfExpressionWithoutApplying(
           closure, CS.DC, decl, FreeTypeVariableBinding::Disallow);
 
-      if (type && resultTypeProcessor(*type, expectedResultType))
+      if (type && resultTypeProcessor(type, expectedResultType))
         return true;
     }
 
@@ -7825,7 +7825,7 @@ bool FailureDiagnosis::visitKeyPathExpr(KeyPathExpr *KPE) {
         &listener);
 
     if (derivedType) {
-      if (auto *BGT = (*derivedType)->getAs<BoundGenericClassType>()) {
+      if (auto *BGT = derivedType->getAs<BoundGenericClassType>()) {
         auto derivedValueType = BGT->getGenericArgs().back();
         if (!CS.TC.isConvertibleTo(valueType, derivedValueType, CS.DC)) {
           diagnose(KPE->getLoc(),
@@ -8986,7 +8986,7 @@ diagnoseAmbiguousMultiStatementClosure(ClosureExpr *closure) {
       auto type = CS.TC.getTypeOfExpressionWithoutApplying(
           resultExpr, CS.DC, decl, FreeTypeVariableBinding::UnresolvedType);
       if (type)
-        resultType = type.getValue();
+        resultType = type;
     }
 
     // If we found a type, presuppose it was the intended result and insert a

lib/Sema/TypeCheckConstraints.cpp

@@ -1820,7 +1820,7 @@ Type TypeChecker::typeCheckExpression(Expr *&expr, DeclContext *dc,
   return cs.getType(expr);
 }
 
-Optional<Type> TypeChecker::
+Type TypeChecker::
 getTypeOfExpressionWithoutApplying(Expr *&expr, DeclContext *dc,
                                    ConcreteDeclRef &referencedDecl,
                                  FreeTypeVariableBinding allowFreeTypeVariables,
@@ -1849,7 +1849,7 @@ getTypeOfExpressionWithoutApplying(Expr *&expr, DeclContext *dc,
                          allowFreeTypeVariables, listener, cs, viable,
                          TypeCheckExprFlags::SuppressDiagnostics)) {
     recoverOriginalType();
-    return None;
+    return Type();
   }
 
   // Get the expression's simplified type.
@@ -1862,7 +1862,7 @@ getTypeOfExpressionWithoutApplying(Expr *&expr, DeclContext *dc,
 
   if (exprType->hasError()) {
     recoverOriginalType();
-    return None;
+    return Type();
   }
 
   // Dig the declaration out of the solution.

lib/Sema/TypeChecker.h

@@ -1592,9 +1592,9 @@ class TypeChecker final : public LazyResolver {
   /// events in the type checking of this expression, and which can introduce
   /// additional constraints.
   ///
-  /// \returns the type of \p expr on success, None otherwise.
+  /// \returns the type of \p expr on success, Type() otherwise.
   /// FIXME: expr may still be modified...
-  Optional<Type> getTypeOfExpressionWithoutApplying(
+  Type getTypeOfExpressionWithoutApplying(
       Expr *&expr, DeclContext *dc,
       ConcreteDeclRef &referencedDecl,
       FreeTypeVariableBinding allowFreeTypeVariables =